Bengfort (7aef0b14) at 28 Mar 12:34
Bengfort (66423286) at 28 Mar 12:33
Bengfort (d5f36b0b) at 28 Mar 12:33
I toyed around with ruff format
. That got me pretty close to fixing the remaining lint errors, so I thought there is really no point in holding this back.
This is a lot. I won't be able to review this this week. My proposal is to disable C9 for now and get back to this later.
Adapt line length in editorconfig
Bengfort (d5f36b0b) at 27 Mar 15:44
fixup 8e5fa678
Bengfort (0374ff67) at 27 Mar 14:55
tweak sessions end email
Bengfort (66423286) at 27 Mar 12:52
Fixup 22715890: rm bootswatch
The reference to it was removed in e71a2210
There are plenty of other options to generate a random string.
Bengfort (7aef0b14) at 27 Mar 12:50
rm generate_secret_key.py
I am a bit torn on this one. I think it is not very meaningful to use btn-sm
with every single button. So I tried to remove that. But admittedly, that resulted in everything being huge. So then I scaled it down again. Not sure about this.
Some of these are non-trivial, so this should be properly reviewed
Bengfort (931bf688) at 27 Mar 12:20
Merge branch 'ruff_fixes_first_pass' into 'main'
... and 3 more commits
For future reference: Both don't work because gettext cannot extract the translatable string.
This whole class is wild. We should definitely refactor this. My first though that this block needs to be wrapped in if classname_cleaned in field_classes:
. But if I understand this correctly, classname_cleaned
is guaranteed to be identical to classname
, so the KeyrError has already been handled above.
I think we can leave it like this for now, but it should definitely be refactored.